Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] MPM supports running in the browser, retaining only the build functionality to reduce size. #3363

Closed
yubing744 opened this issue Apr 23, 2022 · 8 comments
Assignees
Labels
area:mpm enhancement Enhancement help wanted Extra attention is needed

Comments

@yubing744
Copy link

Feature Request

MPM supports running in the browser, retaining only the build functionality to reduce size.

Describe Preferred Solution

Control module compilation by turning on the feature switch, set the compilation target to wasm32-unknown-unknown support running in the browser.

Related Code

(https://github.com/starcoinorg/starcoin/tree/master/vm/move-package-manager)

Additional Context

Like Dove Light - Dove package manager built for Web.

If the feature request is approved, would you be willing to submit a PR?
Yes

@yubing744 yubing744 added the enhancement Enhancement label Apr 23, 2022
@yubing744 yubing744 changed the title [Feature Request] [Feature Request] MPM supports running in the browser, retaining only the build functionality to reduce size. Apr 23, 2022
@jolestar jolestar added help wanted Extra attention is needed area:mpm labels Apr 24, 2022
@yubing744
Copy link
Author

pick!

@yubing744
Copy link
Author

yubing744 commented Apr 30, 2022

Since the browser does not support file operations, compiling move-compiler to wasm-unkown-unkown will fail because it cannot read the file. The solution of the pontem-network team is to let move-compiler provide compilation Callback/Interact, and then wasm implements the file access interface separately. Related Commit: pontem-network/diem@11ae64b

image

@yubing744
Copy link
Author

yubing744 commented Apr 30, 2022

But now move-language/move has no Callback/Interact function.

@jolestar
Copy link
Member

But now move-language/move has no Callback/Interact function.

@yubing744, please create a new Feature Request for the callback requirement.

@yubing744
Copy link
Author

OK

@yubing744
Copy link
Author

@jolestar I have created a new Feature Request for the callback requirement: move-language/move#89

@jolestar
Copy link
Member

jolestar commented Jul 4, 2022

Is this feature implemented in move-js?

@yubing744
Copy link
Author

Is this feature implemented in move-js?

Yes, it can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:mpm enhancement Enhancement help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants