Return error strings with "trivial" closure. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, this just returns an error string as a second return value, if a problem occurred loading the mo file. This follows the Lua idiom established by e.g. io.open(). The client can now handle error conditions, if they care, rather than living with a mysterious, silent failure. I also beefed up the first check for a valid path; `type(mo_file) ~= "string")` will catch nil as well as other types. I checked that this file compiles and handles path errors reasonably. I don't know the .mo format well enough to exercise the other error clauses, but they're pretty straightforward.
starius
added a commit
that referenced
this pull request
May 12, 2015
Return error strings with "trivial" closure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Basically, this just returns an error string as a second return value, if a problem occurred loading the mo file.
This follows the Lua idiom established by e.g. io.open().
The client can now handle error conditions, if they care, rather than living with a mysterious, silent failure.
I also beefed up the first check for a valid path;
type(mo_file) ~= "string")will catch nil as well as other types.I checked that this file compiles and handles path errors reasonably.
I don't know the .mo format well enough to exercise the other error clauses, but they're pretty straightforward.