From 42e6278fb905a5acaaea70d307fe51ccf9f9c932 Mon Sep 17 00:00:00 2001 From: saniksin <35655944+saniksin@users.noreply.github.com> Date: Wed, 30 Jul 2025 03:38:26 +0200 Subject: [PATCH 1/2] Update staking.adoc --- modules/architecture/pages/staking.adoc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/architecture/pages/staking.adoc b/modules/architecture/pages/staking.adoc index 7a54f5c383..989551c882 100644 --- a/modules/architecture/pages/staking.adoc +++ b/modules/architecture/pages/staking.adoc @@ -326,8 +326,9 @@ The following procedures are only intended for developers who are either interes | Entering a delegation pool | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#enter_delegation_pool[`enter_delegation_pool`^] function -a| * `amount` should be denominated in FRI (i.e., 1*10^18^ = 1 STRK) -* You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract's `approve` function +a| * Use this when delegating to a pool **for the first time** +* `amount` should be denominated in FRI (i.e., 1×10^18^ = 1 STRK) +* You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract’s `approve` function | Claiming rewards | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#claim_rewards-1[`claim_rewards`^] function @@ -335,8 +336,9 @@ a| * `amount` should be denominated in FRI (i.e., 1*10^18^ = 1 STRK) | Adding to a delegation pool | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#add_to_delegation_pool[`add_to_delegation_pool`^] function -a| * `amount` should be denominated in FRI (i.e., 1*10^18^ = 1 STRK) -* You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract's `approve` function +a| * Use this when **adding more tokens** to a pool you have already entered +* `amount` should be denominated in FRI (i.e., 1×10^18^ = 1 STRK) +* You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract’s `approve` function | Switching delegation pools | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#switch_delegation_pool[`switch_delegation_pool`^] function From 8b1e0b1130efa0790924506211250f1963962667 Mon Sep 17 00:00:00 2001 From: Raz Landau <125185051+LandauRaz@users.noreply.github.com> Date: Mon, 25 Aug 2025 10:26:13 +0300 Subject: [PATCH 2/2] codereview --- modules/architecture/pages/staking.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/architecture/pages/staking.adoc b/modules/architecture/pages/staking.adoc index 989551c882..165de47742 100644 --- a/modules/architecture/pages/staking.adoc +++ b/modules/architecture/pages/staking.adoc @@ -326,8 +326,7 @@ The following procedures are only intended for developers who are either interes | Entering a delegation pool | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#enter_delegation_pool[`enter_delegation_pool`^] function -a| * Use this when delegating to a pool **for the first time** -* `amount` should be denominated in FRI (i.e., 1×10^18^ = 1 STRK) +a| * `amount` should be denominated in FRI (i.e., 1×10^18^ = 1 STRK) * You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract’s `approve` function | Claiming rewards @@ -336,7 +335,7 @@ a| * Use this when delegating to a pool **for the first time** | Adding to a delegation pool | Invoke the delegation pool contract's https://github.com/starkware-libs/starknet-staking/blob/main/docs/spec.md#add_to_delegation_pool[`add_to_delegation_pool`^] function -a| * Use this when **adding more tokens** to a pool you have already entered +a| * Adding to a delegation pool is only possible after entering it using `enter_delegation_pool` * `amount` should be denominated in FRI (i.e., 1×10^18^ = 1 STRK) * You must first approve the transfer of STRK tokens to the delegation pool contract by invoking the STRK contract’s `approve` function