Skip to content

Merge main-v0.14.2 into main-v0.14.3#14419

Merged
Yoni-Starkware merged 3 commits into
main-v0.14.3from
einatg/merge-main-v0.14.2-into-main-v0.14.3-1780922981
Jun 9, 2026
Merged

Merge main-v0.14.2 into main-v0.14.3#14419
Yoni-Starkware merged 3 commits into
main-v0.14.3from
einatg/merge-main-v0.14.2-into-main-v0.14.3-1780922981

Conversation

@einat-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches block-hash inputs in the OS and version parsing on the proving path; incorrect override or fallback logic could break virtual OS hash consistency with on-chain blocks.

Overview
Adds support for proving against base blocks whose on-chain Starknet version string is newer than the binary’s latest StarknetVersion enum, so virtual OS block-hash checks still match chain commitments.

OS input & hints: OsBlockInput gains optional starknet_version_override. In get_block_hashes, the OS now inserts the version into Cairo memory via ascii_as_felt on either that override or block_info.starknet_version.to_string(), instead of converting the parsed enum to a felt—matching how the on-chain block hash commits to the exact ASCII version string.

Transaction prover path: BaseBlockInfo stores raw_starknet_version from the RPC header. BaseBlockInfo::new maps unknown-but-newer versions to StarknetVersion::LATEST for blockifier execution via new starknet_version_or_latest, while preserving the raw string for the OS. VirtualOsBlockInput / OsHints set starknet_version_override to that raw string. Flow tests and storage proof tests wire None or LATEST where appropriate.

Tests: Expanded virtual_block_executor_test for version fallback, rejection of invalid/old unknown versions, and starknet_version_or_latest edge cases.

Reviewed by Cursor Bugbot for commit bc3e5fb. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main-v0.14.3 with commit e454df0 Jun 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants