Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AVX backend #616

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove AVX backend #616

merged 1 commit into from
May 20, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 4, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (23d2946) to head (50a6982).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #616      +/-   ##
==========================================
- Coverage   93.06%   92.64%   -0.43%     
==========================================
  Files          84       69      -15     
  Lines       11909     8995    -2914     
  Branches    11909     8995    -2914     
==========================================
- Hits        11083     8333    -2750     
+ Misses        744      590     -154     
+ Partials       82       72      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from f55de63 to 63ff9f4 Compare May 15, 2024 04:35
@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from 63ff9f4 to 813449a Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from 813449a to 757b00f Compare May 16, 2024 03:56
Copy link
Collaborator

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Please wait until the merkle simd benchmark is good

Reviewable status: 0 of 25 files reviewed, all discussions resolved

@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from 757b00f to 94e62ff Compare May 16, 2024 15:25
@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from 94e62ff to f5cf441 Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch from f5cf441 to ff7a173 Compare May 19, 2024 14:34
@andrewmilson andrewmilson force-pushed the 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend branch 3 times, most recently from 0304a69 to 5c4b79c Compare May 20, 2024 14:40
Base automatically changed from 05-04-Convert_wide_fibbonacci_AVX_backend_example_to_SIMD_backend to dev May 20, 2024 14:44
@andrewmilson andrewmilson merged commit d4372f9 into dev May 20, 2024
25 of 26 checks passed
@andrewmilson andrewmilson deleted the 05-04-Remove_AVX_backend branch May 20, 2024 14:49
This was referenced Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants