docs: Clarify missing info in 0.45.0 migration doc #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the changes described for format were missing. In one case, a typo was made in the example.
matchai
approved these changes
Oct 1, 2020
chipbuster
pushed a commit
to chipbuster/starship
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the changes described for format were missing. In one case, a typo was made in the example.
The translations, I’ll need some help with those; I only speak & write English.
Motivation and Context
Going through the migration guide, I noticed some errors.
How Has This Been Tested?
Checklist: