Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md with instructions for termux #2257

Merged
merged 2 commits into from Feb 21, 2021
Merged

docs: Update README.md with instructions for termux #2257

merged 2 commits into from Feb 21, 2021

Conversation

gunslingerfry
Copy link
Contributor

Description

Added install steps for termux

Motivation and Context

Easier install in termux

How Has This Been Tested?

  • I have tested using Linux (Termux)

Checklist:

  • I have updated the documentation accordingly.

@gunslingerfry gunslingerfry changed the title docs Update README.md with instructions for termux docs: Update README.md with instructions for termux Feb 2, 2021
@andytom
Copy link
Member

andytom commented Feb 3, 2021

Thanks for the contribution @gunslingerfry, to get the CI to pass can you either update your commit message to include the prefix docs: in the title or just push an empty commit to this branch e.g

git commit --allow-empty -m 'make Semantic PR bot happy'
git push 

Copy link
Contributor

@chipbuster chipbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andytom andytom merged commit 7331e4b into starship:master Feb 21, 2021
@vladimyr
Copy link
Member

vladimyr commented Mar 6, 2021

Is there a reason why we would favor this instead of using the official termux package which we already had mentioned inside our docs (got stripped in the removal of extra installation methods from README)?

@gunslingerfry
Copy link
Contributor Author

gunslingerfry commented Mar 7, 2021 via email

@vladimyr
Copy link
Member

vladimyr commented Mar 7, 2021

No worries, it might be superfluous but still serves people better than lack of any guidance 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants