docs(faq): make uninstall instructions shell-independent

[heyajulia]

Description

The uninstall instructions assume that the user is running Bash, which is a safe bet, but isn't always the case.

Motivation and Context

This change wraps the uninstall command in bash -c, making it shell-independent in most cases. It will close issue #2484.

Closes #2484

Screenshots (if appropriate):

N/A

How Has This Been Tested?

I ran bash -c 'rm "$(which starship)"' to uninstall Starship, and it worked, even though I'm using Fish as my shell (this is good).

• I have tested using MacOS
• I have tested using Linux
• I have tested using Windows

Checklist:

• I have updated the documentation accordingly.
• I have updated the tests accordingly.

[davidkna]

I think the commit message is missing the :. docs(faq): make uninstall instructions shell-independent
Also I'd prefer sh over bash.

[heyajulia]

I think the commit message is missing the :. docs(faq): make uninstall instructions shell-independent

Good catch, thanks!

[vladimyr]

As I said earlier #2484 (comment) this change seems kinda superfluous. If we really want to go in that direction, we should use sh instead to mirror installation instructions.

[vladimyr]

^ @chipbuster

[chipbuster]

Ah, sorry, I think I lost track of the discussion surrounding this PR and thought that that the sh change had already been added. Would it be simplest to just add new PR changing that or do we want to revert this one?

[vladimyr]

Let's add a new one so everybody keeps their contribution! ❤️