Skip to content

Conversation

@cappyzawa
Copy link
Member

Description

Julia's packages have the version in Project.toml .
(ref: The version field)

Motivation and Context

Closes
#1030 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

I tested in LanguageServer.jl/Project.toml at c3e92a494e8613c9cbd35a65140f9f0fc75208d5 · julia-vscode/LanguageServer.jl.

Screen Shot 2020-03-30 at 11 32 00

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@cappyzawa cappyzawa requested a review from a team March 30, 2020 02:34
@andytom andytom changed the title feat: Add project version (for julia) to package module feat(package): Add project version for julia Mar 30, 2020
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@heyrict heyrict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andytom andytom merged commit edcec7e into starship:master Apr 3, 2020
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
* add project version (for julia) to package module

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants