Skip to content

fix(julia): julia icon based on Julia's community standards. #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix(julia): julia icon based on Julia's community standards. #1055

merged 1 commit into from
Apr 7, 2020

Conversation

@cappyzawa
Copy link
Member

@cappyzawa cappyzawa commented Apr 7, 2020 •
edited
Loading

Description

Motivation and Context

Closes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

Screen Shot 2020-04-07 at 11 45 51

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Fix julia icon based on https://julialang.org/community/standards/
01a21c3 
According by this standards
> While "Julia" is a female name in many parts of the world, the programming language is not a person and does not have a gender.
@cappyzawa cappyzawa requested a review from matchai April 7, 2020 02:47
@cappyzawa cappyzawa changed the title Fix julia icon based on Julia's community standards. fix: julia icon based on Julia's community standards. Apr 7, 2020
@cappyzawa
Copy link
Member Author

cappyzawa commented Apr 7, 2020 •
edited
Loading

@waldyrious thanks for your feedback!!

@andytom andytom changed the title fix: julia icon based on Julia's community standards. fix(julia): julia icon based on Julia's community standards. Apr 7, 2020
@andytom andytom merged commit 2f449af into starship:master Apr 7, 2020
@waldyrious
Copy link

waldyrious commented Apr 7, 2020

@cappyzawa thank you for doing this :) I have just announced this feature in the Julia discourse forums. Cheers!

dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
@dagbrown
Fix julia icon based on https://julialang.org/community/standards/ (s…
4cb563b 
…tarship#1055)

According by this standards
> While "Julia" is a female name in many parts of the world, the programming language is not a person and does not have a gender.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andytom andytom andytom approved these changes

@matchai matchai Awaiting requested review from matchai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cappyzawa @waldyrious @andytom