Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove unnecessary parentheses in if condition #566

Merged
merged 1 commit into from Oct 20, 2019

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Oct 19, 2019

Found with clippy ;-)

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@heyrict heyrict changed the title Fix: Useless parenthesis in if condition fix: Useless parenthesis in if condition Oct 20, 2019
Copy link
Contributor

@brianlow brianlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matchai matchai changed the title fix: Useless parenthesis in if condition Refactor: Remove unnecessary parentheses in if condition Oct 20, 2019
@matchai matchai merged commit 7e21f5c into starship:master Oct 20, 2019
@matchai
Copy link
Member

matchai commented Oct 20, 2019

Thank you for the quick fix, @cljoly! 😄

@cljoly
Copy link
Contributor Author

cljoly commented Oct 20, 2019

You're welcome!

hoop33 pushed a commit to hoop33/starship that referenced this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants