Permalink
Browse files

53-psgi-overloaded.t broke under perl 5.8.7.

Seems that the overload "magic" is on the RV in 5.8.7 whereas in 5.12.1 making
a brand new RV seemed to work fine.
  • Loading branch information...
1 parent b7f47da commit 896db071bf5c4810c398cbf02beb2401f8fe9b3a @stash committed Oct 9, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 Feersum.xs
View
@@ -2005,7 +2005,7 @@ request_handler(SV *self, SV *cb)
croak("can't supply an undef handler");
if (request_cb_cv)
SvREFCNT_dec(request_cb_cv);
- request_cb_cv = newRV_inc(SvRV(cb));
+ request_cb_cv = newSVsv(cb); // copy so 5.8.7 overload magic sticks.
request_cb_is_psgi = ix;
trace("assigned %s request handler %p\n",
request_cb_is_psgi?"PSGI":"Feersum", request_cb_cv);

0 comments on commit 896db07

Please sign in to comment.