Improve Windows stash behaviour #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of the windowsgui flag, which causes all sorts of issues. Instead, checks if stash was launched from the icon, and if so hides the console.
kermieisinthehouse
approved these changes
May 2, 2022
There was a problem hiding this comment.
Reviewed but not tested.
Looks good to me, generally. Have you tested getting rid of fixconsole? I think if you got rid of the windowsgui flag, you probably don't need it to fix the shell when running from a console. Otherwise looks good, and having some error handling is nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some issues with the Windows version of stash:
windowsguiflag from the build. This was causing interoperability issues when running from the console, and as far as I can tell was only used to prevent the console window from appearing.IsDesktopfunction to return true if the executable was launched from Windows, rather than invoked from a console. It does this viaisDoubleClickLaunched.IsDesktopreturns true, then hides the console window that appears when launching viahideConsole.IsDesktopis true, and an error occurs on startup, or a panic occurs, a dialog window will be displayed with the error message, instead of crashing silently.Also makes
manager.instancepublic and renames tomanager.Manager.