Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scene duration filter #313

Merged
merged 2 commits into from Jan 13, 2020
Merged

Conversation

@WithoutPants
Copy link
Collaborator

WithoutPants commented Jan 8, 2020

Fixes #261

Adds duration to the scene criteria. Uses the duration control for input.

@WithoutPants WithoutPants added the feature label Jan 8, 2020
@bnkai

This comment has been minimized.

Copy link
Collaborator

bnkai commented Jan 11, 2020

Works fine for me.

Edit: The equals doesn't seem to match anything for me even for 5, 6 sec clips.
The duration in the DB is a float, is there a rounding or flooring done before comparing equality?

@WithoutPants

This comment has been minimized.

Copy link
Collaborator Author

WithoutPants commented Jan 13, 2020

Updated behaviour of duration equals to use duration >= x AND duration < x+1, and not equals to use (duration < x OR duration >= x+1).

@bnkai

This comment has been minimized.

Copy link
Collaborator

bnkai commented Jan 13, 2020

With the latest commit everything tests ok.

@Leopere Leopere requested a review from bnkai Jan 13, 2020
@Leopere Leopere self-assigned this Jan 13, 2020
@Leopere Leopere added this to In progress in Wants via automation Jan 13, 2020
@Leopere Leopere added this to In progress in 1.0 Stable Release via automation Jan 13, 2020
Wants automation moved this from In progress to Reviewer approved Jan 13, 2020
1.0 Stable Release automation moved this from In progress to Reviewer approved Jan 13, 2020
@Leopere Leopere merged commit cf96cae into stashapp:develop Jan 13, 2020
3 checks passed
3 checks passed
ci/dockercloud (/docker/compiler) Your tests passed in Docker Cloud
Details
ci/dockercloud (/docker/production/x86_64) Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Wants automation moved this from Reviewer approved to Done Jan 13, 2020
1.0 Stable Release automation moved this from Reviewer approved to Done Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Wants
  
Done
3 participants
You can’t perform that action at this time.