Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a simple 'enabled' switch for Restic CRD #279

Closed
whereisaaron opened this issue Jan 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@whereisaaron
Copy link
Contributor

commented Jan 5, 2018

I know there are a couple ways to disable backups, but neither are great IMHO. I'd rather not 'lose' the CRD by deleting it, nor 'damage' the CRD (change selector or schedule) just to disable it temporarily.

Could you consider a simple spec.enabled: true/false flag that left the CRD intact but disabled. I guess the only way to communicate that to the sidecar is to patch it back out. But that would be fine.

There would then be an easy way to bulk disable back-ups for a period, then re-enable them later, but patching 'spec.enabled: false' into multiple CRDs.

Disable Backup
To stop taking backup, you can do 2 things:

  1. Delete the Restic CRD. Stash operator will remove the sidecar container from all matching workloads.
  2. Change the labels of a workload. Stash operator will remove sidecar container from that workload. This way you can selectively stop backup of a Deployment, ReplicaSet, etc.

@tamalsaha tamalsaha added this to the 0.7.0 milestone Jan 11, 2018

@whereisaaron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2018

Yay! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.