Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushGateURL not given to sidecar container #283

Closed
galexrt opened this issue Jan 5, 2018 · 0 comments

Comments

@galexrt
Copy link
Contributor

commented Jan 5, 2018

The PushGateURL is not set on the sidecar containers.
Because of that they always use the default URL which is http://stash-operator.NAMESPACE_OF_POD.svc:56789.
This causes no metrics to be delivered to the pushgateway.

Example:
stash-operator Pod with pushgateway is in namespace kube-system and an application Pod is in namespace example then the URL used is "always" http://stash-operator.example.svc:56789.
This was found to be an issue for injected sidecar containers, not for StatefulSets where the args need to be set by the user.

Code ref:
https://github.com/appscode/stash/blob/afa4f8fa82009f53295e0f3551010284e57aa4c5/pkg/cmds/backup.go#L24-L31
https://github.com/appscode/stash/blob/6f10418a9f1389814157ee141fa2fd8a0a9ad46a/pkg/util/kubernetes.go#L221-L227
https://github.com/appscode/stash/blob/6f10418a9f1389814157ee141fa2fd8a0a9ad46a/pkg/util/kubernetes.go#L199-L203

@galexrt galexrt added the bug label Jan 5, 2018

@tamalsaha tamalsaha self-assigned this Jan 5, 2018

tamalsaha added a commit that referenced this issue Jan 5, 2018
tamalsaha added a commit that referenced this issue Jan 5, 2018
tamalsaha added a commit that referenced this issue Jan 5, 2018
tamalsaha added a commit that referenced this issue Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.