Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Repository data in Recovery CRD #436

Merged
merged 7 commits into from Apr 21, 2018

Conversation

Projects
None yet
3 participants
@hossainemruz
Copy link
Member

commented Apr 16, 2018

This PR enable user to use Repository data in Recovery CRD so that they don't have to repeat backend info.

Task List:

  • Code for using Repository data in Recovery CRD
  • Update tests
  • Update docs
  • Update examples

hossainemruz added some commits Apr 15, 2018

@hossainemruz hossainemruz requested review from tamalsaha and diptadas Apr 16, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Apr 16, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #436   +/-   ##
=====================================
  Coverage      84%    84%           
=====================================
  Files           2      2           
  Lines          25     25           
=====================================
  Hits           21     21           
  Misses          2      2           
  Partials        2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564e63a...272791c. Read the comment docs.

@hossainemruz hossainemruz force-pushed the reocovery branch from e77d1c7 to 8a5b1a7 Apr 17, 2018

strings.HasPrefix(r.Spec.Repository, "replicationcontroller.") ||
strings.HasPrefix(r.Spec.Repository, "replicaset.") ||
strings.HasPrefix(r.Spec.Repository, "statefulset.") ||
(strings.HasPrefix(r.Spec.Repository, "daemonset.") && strings.HasSuffix(r.Spec.Repository, nodeName))) {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Apr 21, 2018

Contributor

This nodeName check does not work, since operator is running on different node.

`Restic` will take backup of the volume periodically with a 1-minute interval. You can verify that backup is taking successfully by,

```console
$ kubectl get repository deployment.stash-demo -o yaml

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Apr 21, 2018

Contributor

Why not use the new get snapshots to confirm this?

@tamalsaha tamalsaha merged commit 2657199 into master Apr 21, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the reocovery branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.