Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/util: fix error found by vet #442

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@functionary
Copy link
Contributor

commented Apr 19, 2018

This pull request was made with an automated tool.

The suggested change fixes one or more problems discovered by "go vet".

See https://github.com/functionary/functionary for more details on
the @functionary GitHub user.

pkg/util: fix error found by vet
Vet found the following error:
	pkg/util/kubernetes.go:386: result of fmt.Errorf call not used

The call to fmt.Errorf was being discarded.
This change returns it to the caller as an error value.
@codecov-io

This comment has been minimized.

Copy link

commented Apr 19, 2018

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #442   +/-   ##
=====================================
  Coverage      84%    84%           
=====================================
  Files           2      2           
  Lines          25     25           
=====================================
  Hits           21     21           
  Misses          2      2           
  Partials        2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b93f8...1686a03. Read the comment docs.

@tamalsaha tamalsaha merged commit c6e62f3 into stashed:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tamalsaha

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2018

Thanks bot and bot master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.