Resolve tasks for backup/restore sessions #674

diptadas · 2019-02-15T05:05:48Z

Merge Introduce v1beta1 api #647
Merge Add restic wrapper library #673

Notes

Implicit inputs are collected from backup/restore session, backup config and repositories. For current list see inputs.go.
Inputs to tasks are carried over to functions.
Inputs for resolving tasks: implicit inputs + backup config params
Inputs for resolving functions: inputs to parent task + task params
Host name: host-0
drone/envsubst only works with alphanumeric characters and underscore as key name.

codecov-io · 2019-03-20T05:07:05Z

Codecov Report

Merging #674 into master will decrease coverage by 87.15%.
The diff coverage is 5.94%.

@@             Coverage Diff             @@
##           master     #674       +/-   ##
===========================================
- Coverage     100%   12.84%   -87.16%     
===========================================
  Files           2        3        +1     
  Lines           8      109      +101     
===========================================
+ Hits            8       14        +6     
- Misses          0       94       +94     
- Partials        0        1        +1

Impacted Files	Coverage Δ
pkg/resolve/task.go	`5.94% <5.94%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a74602...3dcb0a4. Read the comment docs.

hossainemruz · 2019-03-20T07:02:08Z

apis/stash/v1beta1/types_helpers.go

+
+// TODO: complete
+func (t TargetRef) IsWorkload() bool {
+	if t.Kind == "Deployment" {


What will happen for other workloads i.e. StatefulSet DaemonSet? However, it has been fixed in my workload controller PR.

tamalsaha · 2019-03-20T08:22:35Z

apis/util.go

@@ -3,3 +3,25 @@ package apis
 var (
 	EnableStatusSubresource bool
 )
+
+const (
+	ModificationTypeInitContainerInjection = "InitContainerInjection"


Where is type ModificationType string ?

tamalsaha · 2019-03-20T08:23:12Z

apis/util.go

+)
+
+const (
+	KindDeployment            = "Deployment"


type TargetKind struct ?

glide.yaml

tamalsaha · 2019-03-20T08:27:48Z

pkg/controller/inputs.go

+
+// TODO: complete
+const (
+	RepositoryProvider   = "REPOSITORY_PROVIDER"


Should be in https://github.com/appscode/stash/tree/master/apis

tamalsaha · 2019-03-20T08:43:15Z

pkg/resolve/task.go

+			inputs[param.Name] = param.Value
+		}
+		// merge/replace backup config inputs
+		inputs = core_util.UpsertMap(o.Inputs, inputs)


System Params > Backup configuration > Task config

- [x] Merge #674 - [x] What should be host-name? - [ ] Set backup/restore session status

**Requirements:** - [x] Merge #647 to master - [x] Merge #673 to master - [x] Merge #674 to master - [x] Merge #671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

**Requirements:** - [x] Merge stashed/stash#647 to master - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#674 to master - [x] Merge stashed/stash#671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

diptadas requested review from tamalsaha and hossainemruz February 15, 2019 05:05

diptadas force-pushed the resolve branch 4 times, most recently from 7f01d47 to aef72cd Compare February 25, 2019 12:12

hossainemruz mentioned this pull request Feb 26, 2019

Update workload controller for new design #675

Merged

24 tasks

diptadas force-pushed the resolve branch 11 times, most recently from 649b205 to 91fc379 Compare February 28, 2019 10:51

diptadas marked this pull request as ready for review March 4, 2019 05:25

diptadas force-pushed the resolve branch from 91fc379 to cb5a617 Compare March 6, 2019 10:14

diptadas added 2 commits March 19, 2019 11:59

Resolve tasks for backup/restore sessions

1748579

Merge params of backup-config and tasks

5617a4a

diptadas force-pushed the resolve branch from cb5a617 to 5617a4a Compare March 19, 2019 06:07

Don't remove empty flags

6a3ca8e

diptadas added 2 commits March 20, 2019 11:55

Set default hostname

afeba16

Remove unused const

3dcb0a4

hossainemruz reviewed Mar 20, 2019

View reviewed changes

hossainemruz previously approved these changes Mar 20, 2019

View reviewed changes

tamalsaha reviewed Mar 20, 2019

View reviewed changes

apis/util.go

)

const (

KindDeployment = "Deployment"

Copy link

Member

tamalsaha Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type TargetKind struct ?

tamalsaha reviewed Mar 20, 2019

View reviewed changes

glide.yaml Show resolved Hide resolved

tamalsaha reviewed Mar 20, 2019

View reviewed changes

Move inputs to apis

19655d5

diptadas dismissed hossainemruz’s stale review via 19655d5 March 20, 2019 08:31

tamalsaha reviewed Mar 20, 2019

View reviewed changes

Update task.go

178c338

tamalsaha approved these changes Mar 20, 2019

View reviewed changes

tamalsaha merged commit 7bdf075 into master Mar 20, 2019

tamalsaha deleted the resolve branch March 20, 2019 08:44

tamalsaha pushed a commit that referenced this pull request Mar 20, 2019

Backup and restore PVC (#676)

30993c0

- [x] Merge #674 - [x] What should be host-name? - [ ] Set backup/restore session status

hossainemruz mentioned this pull request Mar 28, 2019

Allow default backup #367

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve tasks for backup/restore sessions #674

Resolve tasks for backup/restore sessions #674

diptadas commented Feb 15, 2019 •

edited

codecov-io commented Mar 20, 2019 •

edited

hossainemruz Mar 20, 2019

tamalsaha Mar 20, 2019

tamalsaha Mar 20, 2019

tamalsaha Mar 20, 2019

tamalsaha Mar 20, 2019

Resolve tasks for backup/restore sessions #674

Resolve tasks for backup/restore sessions #674

Conversation

diptadas commented Feb 15, 2019 • edited

codecov-io commented Mar 20, 2019 • edited

Codecov Report

hossainemruz Mar 20, 2019

Choose a reason for hiding this comment

tamalsaha Mar 20, 2019

Choose a reason for hiding this comment

tamalsaha Mar 20, 2019

Choose a reason for hiding this comment

tamalsaha Mar 20, 2019

Choose a reason for hiding this comment

tamalsaha Mar 20, 2019

Choose a reason for hiding this comment

diptadas commented Feb 15, 2019 •

edited

codecov-io commented Mar 20, 2019 •

edited