Skip to content

Conversation

@FrittenKeeZ
Copy link
Contributor

@FrittenKeeZ FrittenKeeZ commented Nov 2, 2022

This will ensure localizations are stored correctly (fixes #78)

This will ensure localizations are stored correctly (statamic#78)
@what-the-diff
Copy link

what-the-diff bot commented Nov 2, 2022

  • The method makeModelFromContract in the Term class was changed.
  • In line 54, we see that a variable called $data is being assigned to the result of calling data() on an object passed into this function as its first argument (which I assume is some sort of Contract). This assignment happens using PHP's "=" operator which means it will be evaluated from right-to-left and then stored in memory at whatever location corresponds with $data.
  • On line 55, we see that there has been a change where now instead of assigning fileData() to our variable $data, but otherwise everything else remains unchanged between lines 56 - 58 inclusive: if (! isset($data['template'])) { unset($data['template']); }

@jasonvarga
Copy link
Member

First time I've seen what the diff get this so wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Taxonomies doesn't support multi sites ( multi language )

2 participants