Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong alternate href #182

Closed
rrelmy opened this issue Jun 11, 2021 · 2 comments · Fixed by #193
Closed

Wrong alternate href #182

rrelmy opened this issue Jun 11, 2021 · 2 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@rrelmy
Copy link

rrelmy commented Jun 11, 2021

The alternate meta links generated are not correct

<!-- seo_pro:meta -->
<link rel="alternate" href="https://www.vorn.swiss/about-us" hreflang="en" />
<link rel="alternate" href="https://www.vorn.swiss/about-us" hreflang="de" />


<!-- language selector based on the locales tag -->
<div id="language-switch">
  <a class="language active" href="/about-us"  title="Switch language to EN">EN</a>
  <a class="language " href="/de/about-us"  title="Switch language to DE">DE</a>
</div>

Following code looks wrong, as far as I see there is no ->locales method on the Page

if (! method_exists($this->model, 'locales')) {

@jesseleite jesseleite added the bug Something isn't working label Jul 28, 2021
@ranuss
Copy link

ranuss commented Aug 10, 2021

Is there an update on this one?

@jesseleite
Copy link
Member

@ranuss Tagged 2.3.1 with fix for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants