New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a fieldset property to content and making a field localizable causes other localizable fields in that fieldset lossing their old translated content #1221

Closed
peimn opened this Issue Feb 1, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@peimn

peimn commented Feb 1, 2017

Expected behaviour

The field being localizable and every thing will persist and will be ok

Actual behaviour

The old content of the localaized fields in the fieldset will be cleared and replaced with main locales's content

Steps to reproduce

  1. We have home page (or any other page) that don't have fieldset (there is also no default fieldset here you see) first we insert some content for both locales
  2. Then we make a fieldset for our page and define non localizable fields as localizable and back to cp and refresh the edit page
  3. Change the locale, you will see your old localizable title is missed and filled by main locale's old content

Server configuration

Operating system: macOS

Web server: Nginx

PHP version: 7.1.1

Statamic version: 2.5.1

Updated from an older Statamic or fresh install: Fresh

List of installed addons: Nothing

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Feb 1, 2017

Looks like you've just opened 3 issues that are all basically the same thing?

@peimn

This comment has been minimized.

peimn commented Feb 1, 2017

I just don't want to make it complex, and separated the issues

@peimn

This comment has been minimized.

peimn commented Feb 1, 2017

@jasonvarga there is a different between this issue and issue #1222
On that issue you remove fieldset then you see the issue, here you add fieldset then you see the issue

@peimn peimn changed the title from Making a field localizable causes other localizable fields in that fieldset lossing their content to Adding a fieldset property to content and making a field localizable causes other localizable fields in that fieldset lossing their old content Feb 1, 2017

@peimn peimn changed the title from Adding a fieldset property to content and making a field localizable causes other localizable fields in that fieldset lossing their old content to Adding a fieldset property to content and making a field localizable causes other localizable fields in that fieldset lossing their old translated content Feb 1, 2017

@sebszocinski

This comment has been minimized.

sebszocinski commented May 31, 2018

+1 this just happened to me... any progress on this?

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Nov 30, 2018

I believe this has been fixed for the next release. Please let us know once it's out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment