New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and continue on entry edit shows previous version when static caching turned on #1468

Closed
lukeagsmith opened this Issue Jun 15, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@lukeagsmith

lukeagsmith commented Jun 15, 2017

With Static caching turned on using "half measure".

Expected behaviour

Hitting "Save and continue" on and entry edit screen in the CP should show the version of the content you have just saved.

Actual behaviour

After the save happens you are jumped to the top of the page, the green save confirmation is displayed but when you scroll down the content is the same as when you first loaded the edit screen.

Refreshing the browser shows the latest saved content.

Turning off static caching solves the problem.

Steps to reproduce

  1. Turn on static caching
  2. Edit and entry and make changes
  3. Press save and continue
  4. See that your edits are not showing
  5. Refresh page to see edits

Server Details

Statamic Version:
2.5.10

Updated from an older Statamic or fresh install:
Updated

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Jun 16, 2017

Are you sure it has to do with the static caching setting? Can you try it with it disabled?

@lukeagsmith

This comment has been minimized.

lukeagsmith commented Jun 19, 2017

I did try prior to reporting but I think in my initial tests I turned on "Update the Stache on every request" when I turned off static caching.

I've checked again and this actually appears to be just related to "Update the Stache on every request".

So, regardless of the static cache setting, if "Update the Stache on every request" is off, that is when I see this behaviour.

(Shall I update the issue title?)

@lukeagsmith

This comment has been minimized.

lukeagsmith commented Jun 19, 2017

Further info: just tried this on a different site and I don't get the same behaviour.

The site I'm experiencing this on is much larger.

Could it be the case that the stache doesn't have time to update between the save and the load?

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Jun 19, 2017

In my tests, that seems to be what's happening.

We've already updated this for 2.6. We will perform an AJAX submit and keep you on the page instead of refreshing the page. Your data will stay as-is since no navigation occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment