New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline asset manager cuts off bottom assets' dropdowns #1502

Closed
beckysoll opened this Issue Jul 14, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@beckysoll

beckysoll commented Jul 14, 2017

Expected behaviour

To see the dropdowns

Actual behaviour

bottom one or two dropdowns are not visible as they drop outside of their parent container (.asset-selector .asset-browser-content)

Steps to reproduce

Edit a page or entry with a markdown field, click on the "Add Asset" link at the bottom of the field, attept to view the dropdown from the bottom two assets listed, checked in both firefox and chrome on mac.

To fix

.asset-selector .asset-browser-content { overflow: visible... seems to do the trick

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Jul 20, 2017

I think that change would render the dialog unscrollable.

@beckysoll

This comment has been minimized.

beckysoll commented Jul 20, 2017

Aaah yeah, I didn't have a long enough list of assets to see that. looks like a bit of bottom padding on asset-browser-content would do it (6em seems to work). I'm sure there are many css solutions, it would just be ideal if those menus were consistently usable.

@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Feb 14, 2018

Fixed for next release.

@jackmcdade jackmcdade closed this Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment