New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldsets don't show in CP after updating to 2.6.3 #1547

Closed
lukeagsmith opened this Issue Aug 12, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@lukeagsmith

lukeagsmith commented Aug 12, 2017

Expected behaviour

See the list of fieldsets

Actual behaviour

CP shows create first fieldset page

Steps to reproduce

  1. Upgrade to 2.6.3
  2. Click on fieldsets under configure in the CP

Server Details

Operating System:
macOS Sierra

Web Server:
Valet

PHP Version:
7.1

Statamic Version:
2.6.3

Updated from an older Statamic or fresh install:
Upgraded from 2.5.9

@rrelmy

This comment has been minimized.

rrelmy commented Aug 13, 2017

I can not reproduce this in 2.6.3

@lukeagsmith

This comment has been minimized.

lukeagsmith commented Aug 13, 2017

Error in logs:

[2017-08-12 18:43:39] production.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function path() on null in /Users/luke/sites/foo.com/local/storage/framework/views/ca5e4dcfbe0571b9402ce2410f7e3589:3
@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Aug 14, 2017

Any other details you can provide? What's in your fieldsets directory?

@lukeagsmith

This comment has been minimized.

lukeagsmith commented Aug 14, 2017

A lot!

screen shot 2017-08-14 at 16 12 27

@rrelmy

This comment has been minimized.

rrelmy commented Aug 14, 2017

I can reproduce it, it logs no error. The posted error is from something else.

It must be an error on the frontend side, the ajax call returns all the fieldsets.
To reproduce I just duplicated all my fieldsets by copying them.
image

Not sure what the real problem is

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Aug 14, 2017

Luke sent me his fieldsets. I'll get it. Thanks!

@rrelmy

This comment has been minimized.

rrelmy commented Aug 14, 2017

It breaks if you have more than 16 fieldsets.
Has nothing todo with the pagination size

@rrelmy

This comment has been minimized.

rrelmy commented Aug 14, 2017

The Ajax response is an object instead of an array I wonder how this happens 😄

@rrelmy

This comment has been minimized.

rrelmy commented Aug 14, 2017

@lukeagsmith You can add following method in FieldsetController to temporarily fix it until they officially fix it

Index: statamic/core/Http/Controllers/FieldsetController.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- statamic/core/Http/Controllers/FieldsetController.php	(date 1502657489000)
+++ statamic/core/Http/Controllers/FieldsetController.php	(revision )
@@ -46,7 +46,7 @@
                 'uuid'     => $fieldset->name(), // keeping this here temporarily, just in case.
                 'edit_url' => $fieldset->editUrl()
             ];
-        })->filter()->all();
+        })->filter()->values()->all();
 
         return ['columns' => ['title'], 'items' => $fieldsets];
     }
@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Aug 14, 2017

Thanks Remy.

@jasonvarga jasonvarga closed this Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment