New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on empty search + grey screen showing on live site with debugging turned off #1774

Closed
anthubbard opened this Issue Feb 9, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@anthubbard

anthubbard commented Feb 9, 2018

On a website I have, if you go to the 'search' page with no query string OR try to search with an empty search form (same thing) it fatal errors and throws the grey screen of death. I have debug turned off for my live ENV so no detailed error shows - it just is a grey screen with text 'whoops something went wrong’.

PhilipBoomy also replicated the same error in his site.

So:

  1. please don't fatal error my site with an empty search
  2. please don't show grey screen of death on my live website when I have debug: false in my live ENV

Thanks 👍

Ant

===

Server Details

Operating System: OS X some version

Web Server: Apache

PHP Version: No idea

Statamic Version: 2.8.3

Updated from an older Statamic or fresh install: Update

@peimn

This comment has been minimized.

peimn commented Feb 9, 2018

Also in #1707, I have noticed that the search does not work in other locales than EN. This is because the search method, first of all, tries to manipulate search term to ensure there are not any unwanted characters. As result, empty search terms fall into error too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment