New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Button unreachable when setting focus point of a long image #1797

Closed
christopher-siegel opened this Issue Feb 22, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@christopher-siegel

christopher-siegel commented Feb 22, 2018

Expected behaviour

When setting the focus point the card on the left where the thumbnail is shown and you click to set the focus point should be scrollable.

Actual behaviour

It't not scrollable and when the image is to large vertically (like a full-site-screenshot) you can't reach the save button in the bottom of the card.

Steps to reproduce

  1. Upload vertically big image eg. 800x5000px
  2. Try to set a focus point
  3. can't see or reach save button

Possible fix

The CSS for .focal-point-toolbox needs a height and overflow-y: auto. This allows to scroll the card and reach the save button. The scrollbar should only show if the image is too tall (at least in chrome).

Code that works for me, last two lines added (overflow-y and height):

.focal-point-toolbox {
    position: absolute;
    top: 20px;
    left: 20px;
    z-index: 120;
    width: 360px;
    padding: 15px;
    overflow-y: auto;
    height: 95vh;
}
@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Mar 29, 2018

Nice catch. Went with max-height to account for not super tall images :)

@jasonvarga jasonvarga closed this Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment