New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping between username and email-login with php please convert:email-login deletes all users #1944

Closed
danfascia opened this Issue May 22, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@danfascia

danfascia commented May 22, 2018

Describe the bug
When I try to switch between using a username and an email address as login identity php please convert:email-login deletes all users .yaml files.

Expected behavior
Should swap between username and email account login mode without any destructive changes and should still show full fieldset in control panel

Environment details (please complete the following information):

  • Statamic Version 2.9.1
  • Fresh Install
  • OS: OSX
  • Browser: Chrome
  • Web Server: Valet
  • PHP Version: 7.2
  • Addons installed: Charge, Workshop, VideoEmbed
@jasonvarga

This comment has been minimized.

Member

jasonvarga commented May 22, 2018

Works fine here. Can you give any more details? What was the output in your terminal when you ran the command?

@danfascia

This comment has been minimized.

danfascia commented May 22, 2018

users -bash 109x36 2018-05-22 19-52-17

There is a demo with only 1 user which it just wipes, as shown by the lack of result on the ls commands

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented May 22, 2018

What was the file's filename and contents before it got deleted?

@danfascia

This comment has been minimized.

danfascia commented May 22, 2018

email@address.com.yaml

It contained the dataset corresponding to the basic user.yaml fieldset and each field contained something.

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented May 22, 2018

Before it got deleted the filename was already an email address?

@danfascia

This comment has been minimized.

danfascia commented May 22, 2018

Yes

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented May 22, 2018

Why are you running the command then?

@danfascia

This comment has been minimized.

danfascia commented May 22, 2018

I ran it because I thought it might sort out my missing fields in the control panel when I was working in email-login mode, and instead it deleted all my users.

I appreciate (now) that the intended behaviour is a one-time conversion of usernames > email addresses but it's a pretty bad behaviour for it to remove all users without warning regardless.

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented May 22, 2018

Fixed for next release.

@jasonvarga jasonvarga closed this May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment