New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid always stacked if conditional on field #2057

Closed
edalzell opened this Issue Jul 14, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@edalzell

edalzell commented Jul 14, 2018

Describe the bug
In an addon's settings, if you have a grid that's conditional on another field, the grid is always in stacked mode, instead of table

To Reproduce
Steps to reproduce the behavior:

  1. Create addon settings w/ these fields:
fields:
  add_new_users:
    type: toggle
    display: Add New Users?
  user_merge_fields:
    type: grid
    display: 'Merge & Form Field Mapping'
    fields:
      tag:
        type: text
        display: Mailchimp Merge Tag
        instructions: **Case Matters**! Upper case only please.
        width: 50
      field_name:
        type: text
        display: Field Name
        instructions: ' '
        width: 50
    add_row: Add Merge Field
    show_when:
      add_new_users: true
  1. Load the addon settings

Expected behavior
That grid is in table mode

Screenshots
2018-07-13 at 9 30 pm

vs
2018-07-13 at 9 31 pm

Environment details (please complete the following information):

  • Statamic Version: 2.9.8

@jasonvarga jasonvarga changed the title from Addon Settings - Grid always stacked if conditional on field to Grid always stacked if conditional on field Jul 18, 2018

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Jul 18, 2018

Not specific to addon settings, but fixed for next release nonetheless.

@jasonvarga jasonvarga closed this Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment