New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale with relate tag changed/broken from 2.8 to 2.10 #2089

Closed
FrittenKeeZ opened this Issue Jul 30, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@FrittenKeeZ

FrittenKeeZ commented Jul 30, 2018

Describe the bug
We have a very simple alternate canonical tag generator for SEO:

{{ locales current_first="false" }}
    {{ relate:page:id :locale="locale:key" }}
        <link rel="alternate" hreflang="{{ locale:key }}" href="{{ permalink }}" />
    {{ /relate:page:id }}
{{ /locales }}

This has stopped working in 2.10, only outputting the link for the default locale, though still looped for each locale. I have absolutely no idea how to fix this, as it worked in 2.8.

To Reproduce
Steps to reproduce the behavior:

  1. Paste the above snippet in to <head>
  2. See that the generated links are the same regardless of locale.

Expected behavior
Locale specific URLs are generated for the page.

Environment details (please complete the following information):

  • Statamic Version: 2.10.2
  • Fresh Install or Upgrade: Upgrade from 2.8.10
  • OS: Alpine Linux 3.7
  • Browser: any
  • Web Server: Nginx
  • PHP Version: 7.1
@FrittenKeeZ

This comment has been minimized.

FrittenKeeZ commented Jul 31, 2018

Real issue is #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment