New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit esc to close modals #2197

Closed
peimn opened this Issue Oct 11, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@peimn

peimn commented Oct 11, 2018

I always hit ESC to close modals but it just exits Safari from full screen 馃槱
Can we have this feature? 馃榾

@jesseleite

This comment has been minimized.

Member

jesseleite commented Oct 26, 2018

Technically it was already a feature, but didn't always work depending on which DOM element was in focus. Fixed in next release 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment