New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in {{ get_values }} introduced in 2.0.4 #675

Closed
curtisblackwell opened this Issue May 11, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@curtisblackwell

curtisblackwell commented May 11, 2016

In working on #657, a couple new bugs were introduced.

ErrorException in GetValueTags.php line 23:
Undefined variable: filters

The call to undefined $filters is: unset($filters['from']);

Simply removing this is no good either, b/c the returned data will be null.

My hotfix:

:21-23

if ($from = $this->get('from')) {
    $content = Content::get($from);
}

:31-33

$filters = $this->parameters;
unset($filters['from']);
if ($filters) {
@edalzell

This comment has been minimized.

edalzell commented Mar 9, 2017

@curtisblackwell this still exist?

@curtisblackwell

This comment has been minimized.

curtisblackwell commented Mar 10, 2017

@edalzell ¯\_(ツ)_/¯ I doubt it.

@edalzell

This comment has been minimized.

edalzell commented Mar 11, 2017

Can you close then?

@jasonvarga jasonvarga closed this Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment