New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat env vars in addon settings the same as in core settings #846

Closed
curtisblackwell opened this Issue Aug 9, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@curtisblackwell

curtisblackwell commented Aug 9, 2016

Steps to reproduce

  1. Set addon settings in env vars.
  2. Visit addon settings page in CP.

Expected behaviour

I expected to see:

Managed externally by your environment.

Actual behaviour

I saw the parsed values of the environment variables.

@jcohlmeyer

This comment has been minimized.

jcohlmeyer commented Jan 6, 2017

I also see this issue in my addon. Also saving the settings changes the settings in the addon folder, not the enviroment file. Very confusing for the user as it looks like nothing happened.

@edalzell

This comment has been minimized.

edalzell commented Jan 6, 2017

Similar to #1073?

@curtisblackwell

This comment has been minimized.

curtisblackwell commented Jan 6, 2017

@jcohlmeyer it shouldn't change the settings in .env. That has to be done directly in the file.

@jcohlmeyer

This comment has been minimized.

jcohlmeyer commented Jan 6, 2017

Yes @edalzell it is similar to #1073 I think it is actually closer to what I mean.

The settings are saved in the addon's setting file even though they are overridden by the environment settings file. Changing the settings in the CP saves the settings to the addon's settings file, which is confusing because you do not see those changes in CP. You should not be able to edit these values at all when they are controlled by the environment settings file as per your point @curtisblackwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment