New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown field format breaking #930

Closed
jeremydouglas opened this Issue Sep 7, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@jeremydouglas

jeremydouglas commented Sep 7, 2016

Expected behaviour

Markdown field will save properly.

Actual behaviour

Markdown field is saved starting with a pipe character and tabbed indents for each line.

Steps to reproduce

  1. Save content from Control Panel with Markdown field nested in a Replicator.
  2. Accidentally enter a few hard returns at the end of the textarea.
  3. View live page.
  4. Markdown content gets thrown off by an added pipe character to the beginning and tab indenting to each line.

Here's a screenshot of how it ends up:

screen shot 2016-09-07 at 11 33 32 am

And in the template:

screen shot 2016-09-07 at 12 14 15 pm

Seems to happen when there are hard returns at the end of a textarea. I'm not sure if there are other instances that will trigger this as well.

Server configuration

Operating system: Ubuntu

Web server: Linode

PHP version: 7

Statamic version: 2.1.6

Updated from an older Statamic or fresh install: Updated from V1, but this is a new Fieldset and Collection.

Logs

From my server error log

[Wed Sep 07 15:32:22.884057 2016] [proxy_fcgi:error] [pid 22461:tid 140533619984128] (104)Connection reset by peer: [client 72.38.112.218:57574] AH01075: Error dispatching request to : (passing brigade to output filters), referer: http://wentworthlandscapes.com/blog/bridal-wreath-spirea
[Wed Sep 07 15:32:22.910761 2016] [proxy_fcgi:error] [pid 22210:tid 140533678733056] (104)Connection reset by peer: [client 72.38.112.218:57576] AH01075: Error dispatching request to : (passing brigade to output filters), referer: http://wentworthlandscapes.com/blog/bridal-wreath-spirea
[Wed Sep 07 15:32:23.266870 2016] [proxy_fcgi:error] [pid 22461:tid 140533578020608] (104)Connection reset by peer: [client 72.38.112.218:57594] AH01075: Error dispatching request to : (passing brigade to output filters), referer: http://wentworthlandscapes.com/blog/bridal-wreath-spirea

@jackmcdade jackmcdade added the bug label Sep 7, 2016

@jeremydouglas

This comment has been minimized.

jeremydouglas commented Sep 28, 2016

@edalzell helped me out on this. We found that it is an issue with spyc. @jasonvarga has an open issue.

There is a fix. We've requested a release.

Can anything be done to encourage that release?

@edalzell

This comment has been minimized.

edalzell commented Sep 28, 2016

I reached out to the dev on twitter and email but no response.

@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Sep 28, 2016

We can peg composer on a specific commit, but we'll want watch for updates after that.

@edalzell

This comment has been minimized.

edalzell commented Sep 28, 2016

The commit is here @jackmcdade

@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Sep 28, 2016

Yep got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment