New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty array causes a `looped_tags` error #962

Closed
edalzell opened this Issue Sep 16, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@edalzell

edalzell commented Sep 16, 2016

This data:
v2 devplacid 2016-09-15 18-13-27

Used in this template:

     {{ departments }}
       <div class="department {{ name|slugify }}">
         {{ jobs }}
           {{ if first }}
             <h4 class="department-title">{{ name }}</h4>
             <a class="department-content-trigger" data-dept-trigger-text="Show positions" data-dept-trigger-text-swap="Hide positions" href="#">Show positions</a>
             <div class="department-content">
                 {{ /if }}
           <div class="job-item">
             <p class="job-title"><a href="/about/careers/job?jobid={{ id }}">{{ title }}</a></p>
             <p class="job-location">{{ location }}{{ name }}{{ /location }}</p>
           </div>

           {{ if last }}</div>{{ /if}}
         {{ /jobs }}
       </div>
       <!-- </div> -->
     {{ /departments }}

Causes a looped_tags error

@vladdu

This comment has been minimized.

vladdu commented Jun 12, 2017

The same happens with all arrays, most visible probably when a blog post has no tags attached, using the stock Redwood theme. It feels clunky to need to check if the array is empty, and even if that would be the recommended way, the Redwood theme should use it.

I see now this issue is old-ish...

@anthubbard

This comment has been minimized.

anthubbard commented Jul 18, 2017

Hi Jason,

Do you have a rough timeline on when this will be fixed (2.6 released)? This shows on my empty replicator loops - is there a temp fix / way to not display the error?

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Jul 18, 2017

{{ if replicator }} {{ replicator }} ... {{ /replicator }} {{ /if }}

@jasonvarga jasonvarga closed this Jul 18, 2017

@anthubbard

This comment has been minimized.

anthubbard commented Jul 18, 2017

Well thats embarrassing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment