New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.12+ Move/support locale/translations folder outside /statamic #991

Closed
ebeauchamps opened this Issue Sep 26, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@ebeauchamps

ebeauchamps commented Sep 26, 2016

Expected behavior

When upgrading, we should never lose our own locale folder(s) that is/are in use for translating the CP

Actual behaviour

Any folder located in resources/lang/ is cleared when upgrading. The en folder is swapped for a fresh one, but any locale folder within lang is completely cleared! The locale folder should be located in a folder that is not cleared when upgrading (like in EE) OR the locale strings should be downloaded from a central repo (CDN, like in CRAFT) each time you upgrade

This problem was detected with 2.0

Related to #980

@ebeauchamps ebeauchamps changed the title from 2.1.12+ Put the lang folder in another path! to 2.1.12+ Please put the lang folder in another path! Sep 26, 2016

@jackmcdade jackmcdade changed the title from 2.1.12+ Please put the lang folder in another path! to 2.1.12+ Move/support locale/translations folder outside /statamic Sep 27, 2016

@jasonvarga

This comment has been minimized.

Member

jasonvarga commented Sep 27, 2016

We have this on our internal to-do list. Good to have this here too, though.

@ebeauchamps

This comment has been minimized.

ebeauchamps commented Sep 27, 2016

Great!

@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Sep 27, 2016

@ebeauchamps would it possible to send us a copy of your lang folder for us to test?

@ebeauchamps

This comment has been minimized.

ebeauchamps commented Sep 27, 2016

Can you get it from here?

statamic/i18n#64

If not, I can send it to you (2.1.11, because 2.1.12 isn't fully completed yet)
Let me know

@jackmcdade

This comment has been minimized.

Member

jackmcdade commented Sep 27, 2016

Ahh yes this is great. That repo is still setup for v1 which why we haven't merged your PR yet.

@ebeauchamps

This comment has been minimized.

ebeauchamps commented Oct 1, 2016

Great work on this! Thanks.

@ebeauchamps ebeauchamps closed this Oct 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment