Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest #18

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix pytest #18

merged 1 commit into from
Nov 11, 2020

Conversation

panesofglass
Copy link
Contributor

My test run failed due to a missing js2py dependency, so I added that and froze the dependencies.

@davidkpiano
Copy link
Member

Thanks, wondering if adding just Js2Py is sufficient, or are all the other deps necessary to be in the requirements file?

@panesofglass
Copy link
Contributor Author

@davidkpiano probably just Js2Py is sufficient. I typically use the pip freeze > requirements.txt, but I would be happy to revert and add just the one dependency if you prefer. I'll update the PR.

@davidkpiano
Copy link
Member

@davidkpiano probably just Js2Py is sufficient. I typically use the pip freeze > requirements.txt, but I would be happy to revert and add just the one dependency if you prefer. I'll update the PR.

Sure, can you revert it to just one dep? Thank you!

@panesofglass
Copy link
Contributor Author

@davidkpiano done

@davidkpiano davidkpiano merged commit 72d82af into statelyai:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants