Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec-WebSocket-Protocol #70

Closed
darkl opened this issue Apr 22, 2013 · 9 comments

Comments

@darkl
Copy link
Collaborator

@darkl darkl commented Apr 22, 2013

Hi,

I am trying to implement a WAMP protocol (www.wamp.ws) framework in C# using Fleck.
It seems that the autobahn expects me to send a Sec-WebSocket-Protocol:wamp header in the handshake.

How can I accomplish this using Fleck?

@statianzo

This comment has been minimized.

Copy link
Owner

@statianzo statianzo commented Apr 22, 2013

Fleck currently isn't capable of subprotocol negotiation. Is this something you'd be interested in working on?

@darkl

This comment has been minimized.

Copy link
Collaborator Author

@darkl darkl commented Apr 22, 2013

Yes, I'd like to implement my Wamp framework using Fleck, it's a very nice and simple WebSocket implementation.

@statianzo

This comment has been minimized.

Copy link
Owner

@statianzo statianzo commented Apr 22, 2013

Write a tested pull request and I'll get it merged in.

@adam-may

This comment has been minimized.

Copy link

@adam-may adam-may commented May 6, 2013

I've submitted a pull request for #72. This is a superset of #71, where only the Sec-WebSocket-Protocol string was exposed.

This commit extends that concept by adding a WAMP handler that converts the raw messaging delegates into WAMP messages, as defined by http://www.wamp.ws/spec.

@darkl

This comment has been minimized.

Copy link
Collaborator Author

@darkl darkl commented Jun 16, 2013

@statianzo, What about this? @adam-may has submitted a pull request for this. I tried it and it looks like it works.
What is missing in order to merge this pull request?

@adam-may

This comment has been minimized.

Copy link

@adam-may adam-may commented Jun 17, 2013

@darkl - The original issue was that WAMP has a few extra dependencies (i.e. JSON for message parsing) and my original implementation had it all wrapped up into the Fleck project - meaning that you would have to pay the tax of the overhead even if you weren't using WAMP over WebSockets.

Off the back of that feedback from @statianzo, I went back and refactored/separated the protocol from the Fleck project - the results which can be found in my Fleck.Wamp repository.

See my last comment in pull request #72 (comment) for more details of the new work.

@darkl

This comment has been minimized.

Copy link
Collaborator Author

@darkl darkl commented Jun 17, 2013

@adam-may - I need only the Sec-WebSocket-Protocol support, which is included in #71.
Is there any problem with this pull request? I don't see any WAMP dependencies here.

@darkl darkl closed this Jun 17, 2013
@darkl darkl reopened this Jun 17, 2013
@darkl

This comment has been minimized.

Copy link
Collaborator Author

@darkl darkl commented Jul 2, 2013

@statianzo - any comments about this?

@statianzo

This comment has been minimized.

Copy link
Owner

@statianzo statianzo commented Jul 7, 2013

Just pushed nuget 0.9.7.22 with support for subprotocols. Instructions are available in the readme.

@statianzo statianzo closed this Jul 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.