Sec-WebSocket-Protocol

[darkl]

Hi,

I am trying to implement a WAMP protocol (www.wamp.ws) framework in C# using Fleck.
It seems that the autobahn expects me to send a Sec-WebSocket-Protocol:wamp header in the handshake.

How can I accomplish this using Fleck?

[statianzo]

Fleck currently isn't capable of subprotocol negotiation. Is this something you'd be interested in working on?

[darkl]

Yes, I'd like to implement my Wamp framework using Fleck, it's a very nice and simple WebSocket implementation.

[statianzo]

Write a tested pull request and I'll get it merged in.

[adam-may]

I've submitted a pull request for #72. This is a superset of #71, where only the Sec-WebSocket-Protocol string was exposed.

This commit extends that concept by adding a WAMP handler that converts the raw messaging delegates into WAMP messages, as defined by http://www.wamp.ws/spec.

[darkl]

@statianzo, What about this? @adam-may has submitted a pull request for this. I tried it and it looks like it works.
What is missing in order to merge this pull request?

[adam-may]

@darkl - The original issue was that WAMP has a few extra dependencies (i.e. JSON for message parsing) and my original implementation had it all wrapped up into the Fleck project - meaning that you would have to pay the tax of the overhead even if you weren't using WAMP over WebSockets.

Off the back of that feedback from @statianzo, I went back and refactored/separated the protocol from the Fleck project - the results which can be found in my Fleck.Wamp repository.

See my last comment in pull request #72 (comment) for more details of the new work.

[darkl]

@adam-may - I need only the Sec-WebSocket-Protocol support, which is included in #71.
Is there any problem with this pull request? I don't see any WAMP dependencies here.

[darkl]

@statianzo - any comments about this?

[statianzo]

Just pushed nuget 0.9.7.22 with support for subprotocols. Instructions are available in the readme.