Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't actually retry expired jobs #73

Closed
swrobel opened this issue May 27, 2020 · 1 comment · Fixed by #75
Closed

Can't actually retry expired jobs #73

swrobel opened this issue May 27, 2020 · 1 comment · Fixed by #75

Comments

@swrobel
Copy link
Collaborator

swrobel commented May 27, 2020

This isn't a que-web bug per se, but it is a bit confusing. If a job's error_count has exceeded max_retry_count and expired_at has a value, this job is effectively "dead" and yet que-web allows you to retry it, and gives the impression that it has been retried (run_at updates) - yet the job is not actually re-run. I don't know if there's a way around this, though I've opened an issue with que to find out - if so, we should fix in que-web, otherwise add some logic to disable the retry button for such jobs.

@statianzo
Copy link
Owner

I'm onboard with having the ability to retry expired jobs. Would give a way to manually deal with dead jobs beyond deleting.

Maybe setting expired_at=NULL on retry would be enough given the :poll_jobs SQL doesn't pay any attention to error_count, it only looks for expired_at IS NULL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants