vertical-rhytm and typography fix for small element #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Coobaha
force-pushed
the
master
branch
2 times, most recently
from
61c3136 to
57599e9
Compare
Member
|
Looks great, just one small comment! |
Contributor
Author
|
@Jenius fixed :) |
Member
|
Perfect, thanks for the tight attention to detail here! |
jescalan
pushed a commit
that referenced
this pull request
Sep 17, 2014
vertical-rhytm and typography fix for small element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
fix for vertical-rhythm issue with
smallelement.smallwithout forced line-height or vertical-align makes block-level element a little bit bigger then it must be with its line-height :(checked in latest chrome, firefox. also bootstrap got the same fix for small in headings.