Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.6 #174

Merged
merged 4 commits into from Jun 24, 2022
Merged

Drop support for python 3.6 #174

merged 4 commits into from Jun 24, 2022

Conversation

killjoy1221
Copy link
Contributor

Python 3.6 is end of life.

Also added 3.10 to tox and gh-actions

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #174 (5034392) into main (3733b27) will not change coverage.
The diff coverage is n/a.

❗ Current head 5034392 differs from pull request most recent head efc2058. Consider uploading reports for the commit efc2058 to get more accurate results

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files           5        5           
  Lines         224      224           
  Branches       44       44           
=======================================
  Hits          184      184           
  Misses         27       27           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3733b27...efc2058. Read the comment docs.

@NickCrews
Copy link
Collaborator

NickCrews commented Jun 23, 2022

Hey @killjoy1221, thanks for this! This is totally the right direction. A few minor tweaks:

  • Please remove the commit that adds to .gitignore. If you want to ignore those files, do it in your personal global .gitignore. This .gitignore should stay as lean and specific to this repo as possible
  • Looks like CI fails because python 3.10 is getting interpreted as a float. You need to quote it so it's a string
  • Thanks for updating the CHANGELOG, that's something that's easy to not do! Can you add that we start testing for python 3.10 there as well? And can you rephrase as "Stop testing on Python 3.6"? Because it might still incidentally still work on 3.6, we just don't officially support it.

@@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.7, 3.8, 3.9, 3.10]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "3.10", not just 3.10 which is interpreted as the float 3.1

CHANGELOG.rst Outdated
Changed
^^^^^^^

* Drop support for Python 3.6. See
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually phrase this as "Stop testing for Python 3.6" It still might work, it's just not officially supported.

@killjoy1221
Copy link
Contributor Author

Thanks for the feedback. I think I got everything fixed up.

I've also got a branch adding typing everywhere. Would you be interested in a PR for that?

@killjoy1221
Copy link
Contributor Author

I think black failed because there's a version conflict with click. As a solution, I can either undo the poetry update and leave that for a separate commit/PR or update black to 22.3.0. poetry.lock specifies black-21.12b0

@NickCrews
Copy link
Collaborator

NickCrews commented Jun 24, 2022

EDIT: you just did this, thank you!

That's my read on why black failed as well. Upgrading black to black = { version = "^22.3.0", optional = true } and re-running poetry update would be awesome if you're willing.

@NickCrews NickCrews merged commit 79f470e into staticjinja:main Jun 24, 2022
@NickCrews
Copy link
Collaborator

Thanks @killjoy1221! Do you need a release?

A PR adding typing would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants