New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for python 3.6 #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 5 5
Lines 224 224
Branches 44 44
=======================================
Hits 184 184
Misses 27 27
Partials 13 13 Continue to review full report at Codecov.
|
Hey @killjoy1221, thanks for this! This is totally the right direction. A few minor tweaks:
|
.github/workflows/build.yml
Outdated
@@ -18,7 +18,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, macos-latest, windows-latest] | |||
python-version: [3.6, 3.7, 3.8, 3.9] | |||
python-version: [3.7, 3.8, 3.9, 3.10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "3.10"
, not just 3.10
which is interpreted as the float 3.1
CHANGELOG.rst
Outdated
Changed | ||
^^^^^^^ | ||
|
||
* Drop support for Python 3.6. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you actually phrase this as "Stop testing for Python 3.6" It still might work, it's just not officially supported.
Thanks for the feedback. I think I got everything fixed up. I've also got a branch adding typing everywhere. Would you be interested in a PR for that? |
I think black failed because there's a version conflict with click. As a solution, I can either undo the |
EDIT: you just did this, thank you! That's my read on why black failed as well. Upgrading black to |
Thanks @killjoy1221! Do you need a release? A PR adding typing would be great! |
Python 3.6 is end of life.
Also added 3.10 to tox and gh-actions