Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save period info to metadata model #141

Merged
merged 26 commits into from
Jan 30, 2024
Merged

Save period info to metadata model #141

merged 26 commits into from
Jan 30, 2024

Conversation

mmwinther
Copy link
Member

  • Extract the data from the file path and save it to the model when opening a new dataset.
  • Prevent exceptions when no period info present.

Ref: DPMETA-11

tilen1976 and others added 26 commits January 24, 2024 11:18
@tilen1976
Extract time period from dapla dataset path - set up class, method an…
4d53ede 
…d test for extracting date from
@JanhSander
Started some work
659e799
@mmwinther
First implementation of contains_data_from
f2e46fe
@JanhSander
Just committing what is done today - code not working
97636e6
@JanhSander
Temp save - code not working
341bb25
@JanhSander
Formatting
a231811
@jonolehagemo
Temp save - code not working
71453c0
@mmwinther
Improve structure for test data
b84e995
@mmwinther
Dataclass to store date format information
b2b6b5f
@mmwinther
Remove non-implemented test cases
41805cf
@mmwinther
Raise exception in categorize method
48a8d9a
@mmwinther
Add doctest examples
aba5277
@mmwinther
Support week strings
24f5f48
@tilen1976
Implement derivation of SSB-uniquely formatted dates (#137)
7eaf63e 
* Create class SsbDateFormat for SSB special formats with start and end months for each instance of SsbDateFormat type. Add return type SsbDateFormat on method categorize_period_string. Method get_ssb_period for handling SsDateFormat objects, return string with year and month. Change methods contains_date_from and contains_date_until to handle SsbDateFormat. Add testcases in test_dapla_dataset_path.

* Add doctests for convert_ssb_period.

* Add doctests for SSB date formats to categorize_period_string

* Add docstring for SSB date format  to contains_date_from and contains_date_until

* Correct half-year months and type hint supported_date_formats
@tilen1976
Correct doctest SSB special dates
3af0e7b
@mmwinther
Merge branch 'master' into feature/extract-period-info
35f5016
@tilen1976
add test for failures
71402ab
@tilen1976
Merge branch 'feature/extract-period-info' of https://github.com/stat…
ab301d8 
…isticsnorway/datadoc into feature/extract-period-info
@mmwinther
Merge remote-tracking branch 'origin/master' into feature/extract-per…
5299e59 
…iod-info
@mmwinther
Fix breaking change from dapla-toolbelt
85334a0
@JanhSander @tilen1976 @mmwinther
Saving contains_data_from and contains_data_until to metadata
d2ee2b9 
Co-authored-by: Cecilie Seim <tilen1976@users.noreply.github.com>
Co-authored-by: Miles Mason Winther <mmwinther@users.noreply.github.com>
@JanhSander
Fixing Mypy issue
eaa9da3
@JanhSander
Renaming file
29b9f9e
@mmwinther
Don't raise an Exception when no period string found in dataset path
b8dd4a8
@mmwinther
Merge remote-tracking branch 'origin/master' into feature/save-period…
5d4aa4d 
…-info-to-metadata
@mmwinther
Remove unnecessary comments
8ff5ba9
@mmwinther mmwinther requested a review from a team as a code owner January 30, 2024 12:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tilen1976
tilen1976 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmwinther mmwinther merged commit 097b321 into master Jan 30, 2024
14 checks passed
@mmwinther mmwinther added the enhancement New feature or request label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilen1976 tilen1976 tilen1976 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmwinther @tilen1976 @JanhSander @jonolehagemo