From 0638da7c4909feb5ae36bfee54e4e30e512aa0c3 Mon Sep 17 00:00:00 2001 From: till Date: Mon, 16 Jul 2012 19:51:39 +0200 Subject: [PATCH] Test if the supplied log level is defined in node-syslog. Remove eval()! :) --- exampleConfig.js | 2 +- lib/logger.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/exampleConfig.js b/exampleConfig.js index c62b7b1b..b29443c2 100644 --- a/exampleConfig.js +++ b/exampleConfig.js @@ -42,7 +42,7 @@ Optional Variables: log: log settings [object, default: undefined] backend: where to log: stdout or syslog [string, default: stdout] application: name of the application for syslog [string, default: statsd] - level: log level for syslog [string, default: LOG_INFO] + level: log level for [node-]syslog [string, default: LOG_INFO] */ { diff --git a/lib/logger.js b/lib/logger.js index e14eae92..217f90dc 100644 --- a/lib/logger.js +++ b/lib/logger.js @@ -24,10 +24,13 @@ Logger.prototype = { } else { if (!type) { type = this.level + if (!this.util[type]) { + throw "Undefined log level: " + type; + } } else if (type == 'debug') { type = "LOG_DEBUG"; } - this.util.log(eval("this.util." + this.level), msg); + this.util.log(this.util[type], msg); } } }