From ec4056e507fa7719630e37f04ee77ccb99a451b6 Mon Sep 17 00:00:00 2001 From: draco2003 Date: Thu, 28 Feb 2013 20:57:23 +0000 Subject: [PATCH] Remove extra Object.keys check in the timer_data loop --- backends/graphite.js | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/backends/graphite.js b/backends/graphite.js index 0a57ce3d..79aca15d 100644 --- a/backends/graphite.js +++ b/backends/graphite.js @@ -76,7 +76,7 @@ var post_stats = function graphite_post_stats(statString) { graphiteStats.last_exception = Math.round(new Date().getTime() / 1000); } } -} +}; var flush_stats = function graphite_flush(ts, metrics) { var ts_suffix = ' ' + ts + "\n"; @@ -110,26 +110,23 @@ var flush_stats = function graphite_flush(ts, metrics) { } for (key in timer_data) { - if (Object.keys(timer_data).length > 0) { + var namespace = timerNamespace.concat(key); + var the_key = namespace.join("."); + for (timer_data_key in timer_data[key]) { var namespace = timerNamespace.concat(key); var the_key = namespace.join("."); - for (timer_data_key in timer_data[key]) { - var namespace = timerNamespace.concat(key); - var the_key = namespace.join("."); - - if (typeof(timer_data[key][timer_data_key]) === 'number') { - statString += the_key + '.' + timer_data_key + ' ' + timer_data[key][timer_data_key] + ts_suffix; - } else { - for (timer_data_sub_key in timer_data[key][timer_data_key]) { - l.log(timer_data[key][timer_data_key][timer_data_sub_key].toString()); - statString += the_key + '.' + timer_data_key + '.' + timer_data_sub_key + ' ' + - timer_data[key][timer_data_key][timer_data_sub_key] + ts_suffix; - } + + if (typeof(timer_data[key][timer_data_key]) === 'number') { + statString += the_key + '.' + timer_data_key + ' ' + timer_data[key][timer_data_key] + ts_suffix; + } else { + for (timer_data_sub_key in timer_data[key][timer_data_key]) { + l.log(timer_data[key][timer_data_key][timer_data_sub_key].toString()); + statString += the_key + '.' + timer_data_key + '.' + timer_data_sub_key + ' ' + + timer_data[key][timer_data_key][timer_data_sub_key] + ts_suffix; } } - - numStats += 1; } + numStats += 1; } for (key in gauges) {