Build on FreeBSD 8.4 fails, sequence of #includes in src/networking.c (with patch)

[opsec]

--- src/networking.c.orig 2015-01-14 05:12:08 UTC
+++ src/networking.c
@@ -1,9 +1,9 @@
#include <arpa/inet.h>
#include <fcntl.h>
-#include <netinet/in.h>
-#include <netinet/tcp.h>
#include <sys/socket.h>
#include <sys/types.h>
+#include <netinet/in.h>
+#include <netinet/tcp.h>
#include <sys/uio.h>
#include <syslog.h>
#include <unistd.h>

fixes it.

[opsec]

Also see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196240

[armon]

@opsec Could you clarify the patch? It looks like it was only partially included.

[opsec]

Ups, sorry, cut and paste with the textfield. You can find it here:
https://lists.freebsd.org/pipermail/svn-ports-all/2015-January/083096.html

I'm not yet familiar with the process to submit the patch directly to github (sorry).

[armon]

@opsec That patch is just moving the import lower? Is that actually affecting things? I'm happy to move the import if it matters but it seems like it wouldn't.

[opsec]

Yes, it moves two includes below sys/types.h etc. Yes, it fixes the build on FreeBSD 8.4, where src/networking.c will not build otherwise.

[armon]

Cool, should be fixed!