gmm.IV2SLS has wrong predict signature #1066

Closed
josef-pkt opened this Issue Aug 27, 2013 · 4 comments

Projects

None yet

2 participants

@josef-pkt
Member

after refactoring predict, the predict method in sandbox.regression.gmm.IV2SLS has the wrong signature, exog and params reversed

@jseabold
Member

Is this intended for 0.5.1?

@josef-pkt
Member

We need to do something for 0.5.1.

Minimal change is to just adjust the signature of predict (to adjust to refactoring two releases ago).
But we could also (semi-silently) put my entire GMM branch into the sandbox of 0.5.1, which would also fix smaller bugs.
Or something in between.

@jseabold
Member

Your call.

I'd like to do 0.5.1 sometime this week/weekend, though my internet connectivity on the weekends is spotty right now. Mainly just because if we don't do it now it'll continue to slide.

@jseabold
Member

Closed by #1199.

@jseabold jseabold closed this Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment