Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmm.IV2SLS has wrong predict signature #1066

Closed
josef-pkt opened this issue Aug 27, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Aug 27, 2013

after refactoring predict, the predict method in sandbox.regression.gmm.IV2SLS has the wrong signature, exog and params reversed

@jseabold

This comment has been minimized.

Copy link
Member

commented Oct 23, 2013

Is this intended for 0.5.1?

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2013

We need to do something for 0.5.1.

Minimal change is to just adjust the signature of predict (to adjust to refactoring two releases ago).
But we could also (semi-silently) put my entire GMM branch into the sandbox of 0.5.1, which would also fix smaller bugs.
Or something in between.

@jseabold

This comment has been minimized.

Copy link
Member

commented Oct 24, 2013

Your call.

I'd like to do 0.5.1 sometime this week/weekend, though my internet connectivity on the weekends is spotty right now. Mainly just because if we don't do it now it'll continue to slide.

@jseabold

This comment has been minimized.

Copy link
Member

commented Nov 23, 2013

Closed by #1199.

@jseabold jseabold closed this Nov 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.