Typo in Example Doc? #1116

Closed
jsphon opened this Issue Oct 13, 2013 · 3 comments

Projects

None yet

2 participants

@jsphon
Contributor
jsphon commented Oct 13, 2013

In http://statsmodels.sourceforge.net/devel/examples/generated/ex_arma2.html

I think

In [8]: maparam = np.r_[1, maparams]

should read

In [8]: maparams = np.r_[1, maparams]

@josef-pkt
Member

Thank you for pointing this out

usually I preferred to just call the lag polynomial for just ar and ma:

ma = np.r_[1, maparams]

that would also keep the arparams and maparams around to compare with the estimate.

Do you want to make a pull request to improve the example?

@jsphon
Contributor
jsphon commented Oct 13, 2013

I have done the pull request. It is the first one that I've ever done, so please let me know if I have made a mistake anywhere!

@josef-pkt
Member

PR #1117 has been merged

@josef-pkt josef-pkt closed this Oct 27, 2013
@Padarn Padarn pushed a commit to Padarn/statsmodels that referenced this issue Nov 9, 2013
@jsphon jsphon Update ex_arma2.py
Correcting type, and leaving maparams and arparams around for later comparison.

statsmodels#1116 (comment)
318df49
@jseabold jseabold added a commit that referenced this issue Nov 23, 2013
@jseabold jseabold Backport PR #1117: Update ex_arma2.py
Correcting typo, and leaving maparams and arparams around for later comparison.

#1116 (comment)
966b709
@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@jsphon jsphon Update ex_arma2.py
Correcting type, and leaving maparams and arparams around for later comparison.

statsmodels#1116 (comment)
c02acc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment