no data cleaning for statsmodels.genmod.families.varfuncs.NegativeBinomial() #1122

Closed
t0mpr1c3 opened this Issue Oct 16, 2013 · 3 comments

Projects

None yet

3 participants

@t0mpr1c3

p = self.clean(mu)
return mu + self.alpha_mu
*2

nothing is done with the object p

If the data cleaning is necessary I would have thought the code should be

mu = self.clean(mu)
return mu + self.alpha_mu
*2

@josef-pkt
Member

Thanks for the report, clearly a typo.

a warning:
genmod.NegativeBinomial does not have any unittests so far.
discrete.NegativeBinomial has unittests

@josef-pkt
Member

my mistake: I don't know why I didn't see the tests, when I checked

@jseabold jseabold added a commit to jseabold/statsmodels that referenced this issue Oct 17, 2013
@jseabold jseabold BUG: Fix typo. Use trimmed result. Closes #1122. 294dc27
@jseabold jseabold closed this in d8f1c25 Oct 23, 2013
@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@jseabold jseabold BUG: Fix typo. Use trimmed result. Closes #1122. 203f607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment