Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no data cleaning for statsmodels.genmod.families.varfuncs.NegativeBinomial() #1122

Closed
t0mpr1c3 opened this issue Oct 16, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@t0mpr1c3
Copy link

commented Oct 16, 2013

p = self.clean(mu)
return mu + self.alpha_mu
*2

nothing is done with the object p

If the data cleaning is necessary I would have thought the code should be

mu = self.clean(mu)
return mu + self.alpha_mu
*2

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Oct 16, 2013

Thanks for the report, clearly a typo.

a warning:
genmod.NegativeBinomial does not have any unittests so far.
discrete.NegativeBinomial has unittests

@jseabold

This comment has been minimized.

Copy link
Member

commented Oct 17, 2013

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Oct 17, 2013

my mistake: I don't know why I didn't see the tests, when I checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.