Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: HCCM are now available for WLS #1337

Closed
jseabold opened this issue Jan 28, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@jseabold
Copy link
Member

commented Jan 28, 2014

Need to update the docs to no longer say "HCCM matrices are only appropriate for OLS."

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2014

Probably should also raise a Warning if used after WLS or GLS. For 0.5.1?

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 28, 2014

Probably should also raise a Warning if used after WLS or GLS. For 0.5.1?

That would be better. We could have moved them to OLSResults when we created that.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2014

So what's the right thing to do here? There are about 100 open issues for robust covariances, and I dont find where these were added for WLS/GLS.

Just remove the note about it only being appropriate for OLS? Raise a warning? Refactor?

@josef-pkt josef-pkt added the prio-high label Sep 21, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

I think we can remove all warnings about robust covariances not being available.

relevant issue for WLS is #1209
GLS should work by analogy, but I don't know what to test against in Stata.
I haven't looked at sandwiches for GLSAR yet. I pretty sure HAC can be used to protect against misspecified autocorrelation.

prio-high that I verify a few things

(aside: agile programming: I went through 4, 5 or more rounds of developing the sandwiches, and I lost the overview over all the details.)

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

see #1896 for sandwiches that where still incompletely changed to work for WLS

@josef-pkt josef-pkt removed the prio-high label Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.