Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy min version / issue #1430

Closed
jseabold opened this issue Feb 25, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Feb 25, 2014

I'm doing maintenance on my old box, updating things, etc. and I noticed this.

I don't think this check actually works. AFAICT callback is never removed from the kwargs.

https://github.com/statsmodels/statsmodels/blob/master/statsmodels/base/model.py#L571

Since all the ARMA models pass callback=None up to fit, the lack of reports suggests to me that we don't have anyone running scipy <= 0.12...

@jseabold jseabold added this to the 0.5.1 milestone Feb 25, 2014

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2014

Should at least be fixed for 0.5.1 assuming this refactor affects the 0.5.x series.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Feb 25, 2014

AFAIK, TravisCI uses scipy 0.9 (Ubuntu LTS)
I jswitched recently to scipy 0.12 and to 0.13.3

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2014

Well, all these tests fail for me with scipy 0.12.0.dev-006503d.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Feb 25, 2014

is 0.12.0.dev-006503d a released version or an old buggy scipy master?
I have to check again, I'm pretty sure I used 0.12.0 for a while, but I might never have run the full test suite with it. I think at least one of pythonxy Ubuntu or Nipy Debian uses 0.12.0.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Feb 25, 2014

It is also possible that I never tested for 0.9 < scipy < 0.12.0, but I saw 0.10 also on one of Ubuntu or Debian test machines, IIRC

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2014

Yeah, possible it works in releases, but I don't see callback earlier (I get an error that this keyword doesn't exist), and I don't see that we actually remove the keyword.

scipy/scipy@228baa0

@argriffing

This comment has been minimized.

Copy link

commented Feb 25, 2014

maybe this is or isn't related to your issue, but LooseVersion doesn't work completely correctly with numpy or scipy. There's a scipy thing called 'NumpyVersion' that works.
https://github.com/scipy/scipy/blob/master/scipy/lib/_version.py
It is also copypasted into other projects like
https://github.com/b45ch1/algopy/blob/master/algopy/_npversion.py
It would be tempting to just put it into numpy to avoid all this copypasting, but this doesn't work for obvious reasons...

@jseabold jseabold closed this Sep 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.